Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion of rule collection without rules, but existing event history #97

Open
pbartusch opened this issue Jan 5, 2022 · 1 comment

Comments

@pbartusch
Copy link
Collaborator

A rule collection can be deleted (admin screen), if no rules (inputs) are maintained for it.
Anyway, if that collection has a history of (deleted) events assigned to it, those events will not get deleted, and stay in the database.

There are different options to deal with this:

  1. Do not allow the deletion of a rule collections, if history events are associated with it.
  2. Reconfirm deletion of a rule collection, if history events are associated with it, e.g. "There exist a history for the rule collection. Do you really want to delete it? [Yes] [No]"
  3. Just delete the history without further communication.

I am curious for your thoughts on this.

@MikeAtBT
Copy link

Hi @pbartusch,
why should it even matter, if there's any history event associated with it?
How I understand it: with any creation, edition etc. of a rule, a history event is created.
If this is correct, you would have a history for every collection, that ever held even a single rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants