Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_ssl_cert_check is inverted #73

Closed
vogxn opened this issue Dec 10, 2014 · 1 comment
Closed

skip_ssl_cert_check is inverted #73

vogxn opened this issue Dec 10, 2014 · 1 comment

Comments

@vogxn
Copy link

vogxn commented Dec 10, 2014

When using the cmd line it is passed correctly.

From cmd line:

qds.py --skip_ssl_cert_check --token=$AUTH_TOKEN --url=https://api.qubole.com/api/ --version=latest cluster list --label default

But when called using the SDK's method the argument should be skip_ssl_check=False to skip the verification and skip_ssl_check=True to apply the verification. This is inverted. May be calling the variable ssl_verify=True|False makes more sense

From SDK (to apply SSL check):

Qubole.configure(
        api_token=cfg.get(config.option.environment, 'auth_token'),
        api_url=cfg.get(config.option.environment, 'api_url'),
        skip_ssl_cert_check=True
    )

Because the request args sent is inverted below

kwargs = {'headers': self._headers, 'auth': self.auth, 'verify': not self.skip_ssl_cert_check}
@rohitagarwal003
Copy link
Contributor

I think it's not inverted. When you want to skip verification skip_ should be True, which is the case right now.

Though, I agree that avoiding the double negative should have been better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants