New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator support in miniconf #197

Closed

jordens opened this issue Apr 8, 2024 · 0 comments · Fixed by #198

Member

jordens commented Apr 8, 2024 •

edited

Loading

Maybe it's better to move the validation callbacks out of the mqtt client into miniconf derive, like serde attributes #186 .

More focused validation as opposed to the "global" validator currently
Easier abort on validation fail before setting things, no need to keep backup for roll-back
Unclear how array and option would support these focused validators, maybe not at all
Multiple field level validators or a single struct level or both

jordens added a commit that referenced this issue


          add support for validation callbacks

2d7229a

close #197

jordens linked a pull request

that will close this issue

Merged

ryan-summers closed this as completed in #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment