Qute docs improvement #44289
Qute docs improvement #44289
Conversation
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
melloware
force-pushed
the
Q44261
branch
5 times, most recently
from
de6d636
to
f8e042f
Compare
|
@neon-dev please re-review i think i got all your changes |
Co-authored-by: Neon <[email protected]> Update docs/src/main/asciidoc/qute.adoc Co-authored-by: Neon <[email protected]> Qute docs improvement Update docs/src/main/asciidoc/qute.adoc Co-authored-by: Neon <[email protected]> Qute docs improvement
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Hm, when I think about it, we probably should not make this change at all.
It does not make sense to introduce the goodbye.txt template in the example itself.
The sentence with ItemResource is about grouping templates per resource class (unrelated to the hello example).
CC @FroMage who is the author of the original text about type-safe templates.
CC @ia3andy
|
Yeah, it doesn't add a lot of value to document the second template, we could change the sentence to not mention the second template by name, though, so that people would not think that one is missing from the docs. |
docs/src/main/asciidoc/qute.adoc
Outdated
| Goodbye {name}! <1> | ||
| ---- | ||
| <1> `{name}` is a value expression that is evaluated when the template is rendered. | ||
|
|
||
| Now let's declare and use those templates in the resource class. |
There was a problem hiding this comment.
| Now let's declare and use those templates in the resource class. | |
| Now let's declare and use this template in the resource class. |
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
Co-authored-by: Neon <[email protected]>
|
I am gonna close this. @neon-dev can you submit a new PR please? |
Fix #44261