Qute Character Escapes for Json Content

[ogomezdi]

Changes for covering JSON Escapes in templates mentioned in issue #43369

[github-actions]

🙈 The PR is closed and the preview is expired.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ce8dad0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[gsmet]

@mkouba not sure you are aware of this effort?

[mkouba]

@mkouba not sure you are aware of this effort?

@gsmet I think I was but I forgot ;-).

@ogomezdi Could you squash the commits please?

[ogomezdi]

@mkouba not sure you are aware of this effort?

@gsmet I think I was but I forgot ;-).

@ogomezdi Could you squash the commits please?
Sorry for the inconvenience, it was my first time and I make foolish typo errors in testing class.
The functionality was the one we spoke and agreed long ago @mkouba.
What exactly do you want me to do?

[mkouba]

What exactly do you want me to do?

To squash the commits in one. See for example https://www.git-tower.com/learn/git/faq/git-squash or https://www.geeksforgeeks.org/git-squash/.

[ogomezdi]

What exactly do you want me to do?

To squash the commits in one. See for example https://www.git-tower.com/learn/git/faq/git-squash or https://www.geeksforgeeks.org/git-squash/.

I'm not able to do this :( , my git skills are minimal, and executing commands in examples provided get me to nowhere.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ce8dad0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry-vertx-exporter

✖ io.quarkus.it.opentelemetry.vertx.exporter.grpc.SimpleGrpcNoTLSWithCompressionTest.test - History

• Assertion condition defined as a Lambda expression in io.quarkus.it.opentelemetry.vertx.exporter.AbstractExporterTest Expecting Optional to contain a value but it was empty within 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.it.opentelemetry.vertx.exporter.AbstractExporterTest 
Expecting Optional to contain a value but it was empty within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)

[mkouba]

What exactly do you want me to do?

To squash the commits in one. See for example https://www.git-tower.com/learn/git/faq/git-squash or https://www.geeksforgeeks.org/git-squash/.

I'm not able to do this :( , my git skills are minimal, and executing commands in examples provided get me to nowhere.

No worries, I can do that.

[mkouba]

This pull request is superseded by #44706.

@ogomezdi I wasn't able to merge the commits on your branch either. So I've created a new branch, cherry-picked your commits, rebased and introduced some changes:

1. Added a test to EscapingTest to verify the Quarkus integration
2. Introduced CharReplacementResultMapper that holds the common logic for JsonEscaper and HtmlEscaper.
3. Modified the logic in JsonEscaper to improve the performance (quick benchmark showed the diff ~ 10%).
4. Removed the duplicate parts from the docs.

Let me know what you think.

[ogomezdi]

This pull request is superseded by #44706.

@ogomezdi I wasn't able to merge the commits on your branch either. So I've created a new branch, cherry-picked your commits, rebased and introduced some changes:

1. Added a test to EscapingTest to verify the Quarkus integration
2. Introduced CharReplacementResultMapper that holds the common logic for JsonEscaper and HtmlEscaper.
3. Modified the logic in JsonEscaper to improve the performance (quick benchmark showed the diff ~ 10%).
4. Removed the duplicate parts from the docs.

Let me know what you think.

Great solution!!!
I didn't notice the need of "EscapingTest", simply perfect.
Creating an abstract class, makes easier to understand the logic, despite the performance improvement you've mentioned, and it's convenient for future escape needs in other target formats (YAML, ...)

Thanks a lot!!!
I promise I'll improve my git skills for future pull request.

[mkouba]

This pull request is superseded by #44706.
@ogomezdi I wasn't able to merge the commits on your branch either. So I've created a new branch, cherry-picked your commits, rebased and introduced some changes:

1. Added a test to EscapingTest to verify the Quarkus integration
2. Introduced CharReplacementResultMapper that holds the common logic for JsonEscaper and HtmlEscaper.
3. Modified the logic in JsonEscaper to improve the performance (quick benchmark showed the diff ~ 10%).
4. Removed the duplicate parts from the docs.

Let me know what you think.

Great solution!!! I didn't notice the need of "EscapingTest", simply perfect. Creating an abstract class, makes easier to understand the logic, despite the performance improvement you've mentioned, and it's convenient for future escape needs in other target formats (YAML, ...)

Thanks a lot!!!

You're welcome and thanks for your contribution!

I promise I'll improve my git skills for future pull request.

💯 ;-)