Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation on the usage of io.quarkus.logging.Log in extensions #44575

Open
mcruzdev opened this issue Nov 19, 2024 · 3 comments
Open
Labels

Comments

@mcruzdev
Copy link
Contributor

Description:

The current Quarkus documentation suggests using Log only in application classes, not in external dependencies. However, Log can work in extension modules if they have a Jandex index, although this behavior might not be reliable.

The documentation doesn’t mention that:

  • The stack walk fallback in logging can cause performance issues.
  • Extensions should use standard loggers like Logger.getLogger() instead of Log.
@mcruzdev
Copy link
Contributor Author

cc: @SergioRuyDev do you like to add it?

@Ladicek
Copy link
Contributor

Ladicek commented Nov 19, 2024

The stack walk fallback in logging can cause performance issues

That's because that is only supposed to be triggered in test. It doesn't apply to prod mode, where performance is important.

Copy link

quarkus-bot bot commented Nov 19, 2024

/cc @MichalMaler (documentation), @ebullient (documentation), @inoxx03 (documentation), @michelle-purcell (documentation), @rolfedh (documentation), @sheilamjones (documentation), @sunayna15 (documentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants