Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hibernate-vector integration (through version management OR extension) #41453

Open
lordofthejars opened this issue Jun 26, 2024 · 5 comments
Open
Labels
area/hibernate-orm Hibernate ORM kind/enhancement New feature or request

Comments

@lordofthejars
Copy link
Contributor

Description

Currently (or at least what I've found), to use the hibernate-vector dependency, you need to add the version of Hibernate manually.

<dependency>
            <groupId>org.hibernate.orm</groupId>
            <artifactId>hibernate-vector</artifactId>
            <version>6.4.7.Final</version> <!-- Sets to Hibernate version used by Quarkus -->
        </dependency>

This means you need to explore which Hibernate version is transitively imported by Panache and then hardcoded in the pom.
So, if I update the Quarkus version to a newer version, and the Hibernate version used by Panache is updated too, then my pom might have a divergence in versions.

Implementation ideas

Create an extension that just imports the correct hibernate-vector or a Panache bom so the version of Hibernate is implicitly set.

@lordofthejars lordofthejars added the kind/enhancement New feature or request label Jun 26, 2024
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Jun 26, 2024
Copy link

quarkus-bot bot commented Jun 26, 2024

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@gsmet
Copy link
Member

gsmet commented Jun 26, 2024

If it works out of the box, we can just include it in the BOM. Does it though? :)

@lordofthejars
Copy link
Contributor Author

Yes it works, the only thing is that you need to know beforehand the Hibernate version used by Panache.

@yrodiere
Copy link
Member

Right, we don't necessarily need a separate extension, a BOM entry would be fine as a first step.

The patch is trivial, testing... not so much. I'd need a separate integration test module just for this... including a native build. @gsmet are you fine with that?

@yrodiere yrodiere removed the area/persistence OBSOLETE, DO NOT USE label Aug 14, 2024
@yrodiere
Copy link
Member

yrodiere commented Nov 18, 2024

The patch is trivial, testing... not so much. I'd need a separate integration test module just for this... including a native build. @gsmet are you fine with that?

Let's assume @gsmet is fine with that and add an IT module for pgvector, at least :)

Note we'll need to document this as supported as well.

@yrodiere yrodiere changed the title Adds hibernate-vector extension to not directly depend on Hibernate version hibernate-vector integration (through version management OR extension) Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants