Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling full model name by default #177

Closed
amatsuo opened this issue Oct 22, 2019 · 2 comments
Closed

Calling full model name by default #177

amatsuo opened this issue Oct 22, 2019 · 2 comments
Assignees

Comments

@amatsuo
Copy link
Collaborator

amatsuo commented Oct 22, 2019

At the moment, spacy_initialize use the default model name en. This would become a bit confusing as we are planning to use word-vectors that come with spaCy language models and vectors come only with _lg or _md (#171). Once this is implemented, we expect a number of spacyr users will have multiple models from the same language.

I think we should use a full model name as the default (e.g. the default will be en_core_web_sm) to avoid this confusion.

That's also what @ines recommends:
https://support.prodi.gy/t/spacy-load-en-download/1858

This will be implemented with #171 (unless vetoed by @kbenoit or someone else).

@amatsuo amatsuo self-assigned this Oct 22, 2019
@kbenoit
Copy link
Collaborator

kbenoit commented Oct 23, 2019

I agree, let's implement this in the next update. But as a transitional step, we should map the two-character language names to the "default" language models, if those exist, and print a warning.

@kbenoit
Copy link
Collaborator

kbenoit commented Feb 29, 2020

Now in master.

@kbenoit kbenoit closed this as completed Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants