Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top and bottom types #94

Closed
nsbgn opened this issue Jun 15, 2022 · 2 comments
Closed

Top and bottom types #94

nsbgn opened this issue Jun 15, 2022 · 2 comments

Comments

@nsbgn
Copy link
Contributor

nsbgn commented Jun 15, 2022

Diverting from issue #79: We need a top and bottom type urgently because it will help us in using types of the form F(_) in queries, since we can just search for a subtype of F(Top) instead.

nsbgn added a commit that referenced this issue Jun 16, 2022
See issue #94.

Still need to:

-   Add them to taxonomy.
-   Handle top and bottom types in transformation graphs.
-   Add tests.
-   Replace wildcards in query types with `Bottom`.
@nsbgn
Copy link
Contributor Author

nsbgn commented Jun 16, 2022

Still need to:

  • Add them to taxonomy.
  • Handle top and bottom types in transformation graphs.
  • Add tests.
  • Replace wildcards in query types with Bottom.

@nsbgn nsbgn added this to the Version 0.2: RDF support milestone Jun 16, 2022
nsbgn added a commit that referenced this issue Jun 16, 2022
This will simplify the generation of type taxonomies, which, in turn,
needs to be modified so that it includes top and bottom types as
described in issue #94.
nsbgn added a commit that referenced this issue Jun 19, 2022
Simplifications towards issue #94. The `Language.taxonomy` can be
retired soon.
nsbgn added a commit that referenced this issue Jun 19, 2022
It is now done via canonical nodes, which communicates intent much
better and simplifies working towards #94.

Was announced in commit 6db50ea. See
also the two subsequent commits b2ae9db
and 7b7f4ad.
nsbgn added a commit that referenced this issue Jun 21, 2022
See issue #94. Untested.

This commit changes behaviour, because all sub- and supertypes in a
lineage must now be canonical --- it is no longer possible to have a
canonical root that has non-canonical supertypes.

Also fixed an issue in `.uri()` that goes along with it,
because it allowed unnamed operators to sometimes not throw an error
when put into the taxonomy.
nsbgn added a commit that referenced this issue Jun 23, 2022
Fixes issue #94. The resulting taxonomy is more complicated than I
imagined, so it will need some testing.
@nsbgn
Copy link
Contributor Author

nsbgn commented Jun 23, 2022

Top and bottom types are included. New issue for handling wildcards: #95.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant