Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boot testing to PRs #105

Open
mwasilew opened this issue Dec 9, 2024 · 3 comments
Open

Add boot testing to PRs #105

mwasilew opened this issue Dec 9, 2024 · 3 comments
Assignees
Labels
qa Quality Assurance

Comments

@mwasilew
Copy link
Contributor

mwasilew commented Dec 9, 2024

Boot testing was added in PR #96. This allows to boot test in nightly builds and pushes. There is a mechanism to allow for boot testing on PRs: https://securitylab.github.com/resources/github-actions-preventing-pwn-requests/. Based on this description it should be possible to add boot testing on PRs using workflow_run trigger.

@ndechesne
Copy link
Contributor

Yes, this is correct, pull_request_target would allow us to do that. That's how we did it for meta-qcom in Linaro CI (https://github.com/Linaro/meta-qcom/blob/master/.github/workflows/premerge.yml).

@EmbeddedAndroid EmbeddedAndroid added the qa Quality Assurance label Dec 10, 2024
@quic-kdybcio
Copy link

Make sure to only run these tests for approved runs, so that no one gets the funny idea of setting some voltage regulators too high on our CI farm ;)

@mwasilew
Copy link
Contributor Author

I think physical damage to the hardware is least of my security concerns. Right now the tests are only scheduled for merges and nightly builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa Quality Assurance
Projects
Development

No branches or pull requests

4 participants