Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

Incorporate a build step for sub-modules #83

Closed
jessebeach opened this issue Dec 14, 2013 · 7 comments
Closed

Incorporate a build step for sub-modules #83

jessebeach opened this issue Dec 14, 2013 · 7 comments

Comments

@jessebeach
Copy link
Member

For example, a test for #58 or HTML validation need external libraries.

@kevee
Copy link
Collaborator

kevee commented Dec 14, 2013

How do we feel about using bower for this? I'm also looking at how we handle /dist per #57.

Are we going to need to dynamically load these (require.js?) per a test's dependencies, or will including on the page be the responsibility of the user?

@jessebeach
Copy link
Member Author

Of course there's already a Grunt Task for it :)

https://github.com/yatskevich/grunt-bower-task

Sure, I'm open to exploring Bower. It's got Twitter behind it, so it's not some fly-by-night package manager.

@jessebeach
Copy link
Member Author

I'd need to mess around with the components for a day to get a better understanding of how they'd interact, but in general, I'm never opposed to using existing tools rather than rolling custom code.

@kevee
Copy link
Collaborator

kevee commented Dec 14, 2013

Agreed, the only question is whether we just build in external tools and tell users they need to include them for certain tests, or do we try to load them dynamically when quail needs them? We could have users do something like:

$('#stuff').quail({
  quailPath : '/path/to/quail'
});

Then we use that to see if a test has a dependency and if so just inject a script tag to a required library.

@kevee
Copy link
Collaborator

kevee commented Dec 14, 2013

Added bower-dev branch to test building libs, works well, phantomjs is upset about something with the new version of qunit-composite for some reason, fixing now.

kevee pushed a commit that referenced this issue Dec 18, 2013
Merge bower dev per issue #83
@kevee
Copy link
Collaborator

kevee commented Dec 18, 2013

Merged in bower dev since tests passed and it's a nice standard.

@kevee
Copy link
Collaborator

kevee commented Dec 18, 2013

Closing and updating progress issue on 2.1 release.

@kevee kevee closed this as completed Dec 18, 2013
@kevee kevee mentioned this issue Dec 18, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants