New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

question about the loss function #8

Open

WHUCSLWJ opened this issue Aug 14, 2018 · 1 comment

WHUCSLWJ commented Aug 14, 2018

Could you tell me why you use the L2 distance rather than the Cosine Similarity proposed in the paper?

Author

WHUCSLWJ commented Aug 14, 2018

and why did you use torch.mean() instead of torch.sum() when compute the TripletMarginLoss. As I see in the paper, L=sigma(max(x,0)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment