-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for angular 9 #157
Comments
Use Renderer2 instead of Renderer
…________________________________
Von: Ahmed Benyahia <[email protected]>
Gesendet: Montag, 17. August 2020 15:20
An: qontu/ngx-inline-editor <[email protected]>
Cc: Subscribed <[email protected]>
Betreff: [qontu/ngx-inline-editor] Add support for angular 9 (#157)
Starting from angular 9, Renderer has been renamed to Renderer2.
After upgrading to angular 9 I am getting this error:
ERROR in node_modules/@qontu/ngx-inline-editor/inputs/input-base.d.ts:2:10 - error TS2724: Module '"../../../@angular/core/core"' has no exported member 'Renderer'. Did you mean 'Renderer2'?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#157>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADFEI53KKZ265ALLD53T5RDSBFDDDANCNFSM4QBYHNKQ>.
|
It work as a workaround but it need a proper fix. |
I agree, I mean you have to fork from the repository and fix that. use npm link to use it locally or add it to your project as shared library. Unfortunately the project is not maintained
…________________________________
Von: Ahmed Benyahia <[email protected]>
Gesendet: Montag, 17. August 2020 15:44
An: qontu/ngx-inline-editor <[email protected]>
Cc: ZiedMayel <[email protected]>; Comment <[email protected]>
Betreff: Re: [qontu/ngx-inline-editor] Add support for angular 9 (#157)
It work as a workaround but it need a proper fix.
It's not a good habit to modify the files in node_module manually
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#157 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADFEI5YUZ54XEFSHI67TMMDSBFF4VANCNFSM4QBYHNKQ>.
|
@ZiedMayel Can you please elaborate on the steps to follow? |
What do you need exactly? Can you please tell me what do you mean with "elaborate on the steps"? |
@ZiedMayel I want to use this lib. with angular 10 or are you aware of any alternative to this lib? |
I suggest u create your own lib. I have created a simple component to replace the old one but it's not in a package, you will need to include it manually in the project: https://github.com/SlaySayto/s-inline-editor |
Starting from angular 9, Renderer has been renamed to Renderer2.
After upgrading to angular 9 I am getting this error:
ERROR in node_modules/@qontu/ngx-inline-editor/inputs/input-base.d.ts:2:10 - error TS2724: Module '"../../../@angular/core/core"' has no exported member 'Renderer'. Did you mean 'Renderer2'?
The text was updated successfully, but these errors were encountered: