Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component when deep child is updated #1

Open
qimingweng opened this issue Aug 22, 2015 · 0 comments
Open

Update component when deep child is updated #1

qimingweng opened this issue Aug 22, 2015 · 0 comments

Comments

@qimingweng
Copy link
Owner

Right now the component is updated when the children prop is different. https://github.com/qimingweng/react-center-component/blob/master/src/index.js#L35-L38. However, this could perhaps recursively search through the children to diff...

Or, maybe another approach is to check if the top and left offset are different instead of if the children are different.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qimingweng