Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: classify-* and regress-* actions should accept FeatureTable[RelativeFrequency] #230

Closed
nbokulich opened this issue Dec 15, 2023 · 0 comments · Fixed by #231
Closed

ENH: classify-* and regress-* actions should accept FeatureTable[RelativeFrequency] #230

nbokulich opened this issue Dec 15, 2023 · 0 comments · Fixed by #231
Labels
diff:1|beginner Only limited knowledge of the languages and platform is required. enhancement good first issue Good for newcomers help wanted Extra attention is needed lang:python Python 3

Comments

@nbokulich
Copy link
Member

Addition Description
classify-* and regress-* actions should accept FeatureTable[RelativeFrequency] and maybe a few other types as well (see what is accepted by the split-table action)

I could have sworn that we had an open issue already, but it must have been accidentally closed as it looks like the split-table action accepts multiple types but the training actions do not.

Current Behavior
Only FeatureTable[Frequency] is accepted

Proposed Behavior
Accept other types!
@nbokulich nbokulich added enhancement help wanted Extra attention is needed diff:1|beginner Only limited knowledge of the languages and platform is required. good first issue Good for newcomers lang:python Python 3 labels Dec 15, 2023
@nbokulich nbokulich mentioned this issue Dec 16, 2023
Merged
@colinvwood colinvwood added this to 2024.2 Jan 9, 2024
@colinvwood colinvwood moved this to Changelog Needed in 2024.2 Jan 9, 2024
@lizgehret lizgehret moved this from Changelog Needed to Completed in 2024.2 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diff:1|beginner Only limited knowledge of the languages and platform is required. enhancement good first issue Good for newcomers help wanted Extra attention is needed lang:python Python 3
Projects
No open projects
2024.2
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: accept additional featuretable types nbokulich/q2-sample-classifier
1 participant
@nbokulich