ci: upgrade to Fedora 41 #59595
ci: upgrade to Fedora 41 #59595
Conversation
clang v18 warns about ... src/core/painting/qgsmaskpaintdevice.h:36:5: note: 'QgsMaskPaintEngine' has been explicitly marked deprecated here Q_DECL_DEPRECATED QgsMaskPaintEngine( bool usePathStroker = false ); ... while still being used in src/core/painting/qgsmaskpaintdevice.cpp:65:23: note: in instantiation of function template specialization 'std::make_unique<QgsMaskPaintEngine, bool &>' requested here mPaintEngine = std::make_unique<QgsMaskPaintEngine>( usePathStroker );
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
| @@ -2196,6 +2196,11 @@ else() | |||
| endif() | |||
| endif() | |||
|
|
|||
| # Workaround CLANG deprecation warning | |||
| if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang") | |||
| set_source_files_properties(painting/qgsmaskpaintdevice.cpp PROPERTIES COMPILE_FLAGS "-Wno-deprecated-declarations") | |||
There was a problem hiding this comment.
strange... What are those warnings? Can we not fix them?
There was a problem hiding this comment.
feel free to step in... https://cdash.orfeo-toolbox.org/viewBuildError.php?type=1&buildid=27379
I didn't succeed with the Q_NOWARN_DEPRECATED_PUSH macro, but your experience may help 👍
There was a problem hiding this comment.
try to surround reference to QgsMaskPaintEngine with Q_NOWARN_DEPRECATED_PUSH and Q_NOWARN_DEPRECATED_POP, starting maybe with the declaration on line 89 of qgsmaskpaintdevice.h
Maybe we also should deprecate the whole classes Engine & Device.
There was a problem hiding this comment.
That's what I already tried - it didn't change neither to include the whole two deprecated classes, neither even in combination with Q_NOWARN_DEPRECATED_PUSH/POPping the calls in the qgsmaskpaintdevice.cpp :-( - that's why I turned to this solution which works after all...
Tests failed for Qt 6One or more tests failed using the build from commit a24543e composerlabel_renderhtml (renderAsHtml)composerlabel_renderhtmlTest failed at renderAsHtml at tests/src/core/testqgslayoutlabel.cpp:314 Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtml/expected_composerlabel_renderhtml.png (found 6342 pixels different) composerlabel_renderhtmllineheight (renderAsHtmlLineHeight)composerlabel_renderhtmllineheightTest failed at renderAsHtmlLineHeight at tests/src/core/testqgslayoutlabel.cpp:342 Rendered image did not match tests/testdata/control_images/composer_label/expected_composerlabel_renderhtmllineheight/expected_composerlabel_renderhtmllineheight.png (found 30195 pixels different) picture_svg_fixed_sizepicture_svg_fixed_sizeTest failed at testRenderSvgFixedSize at tests/src/python/test_qgsannotationpictureitem.py:807 Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_fixed_size/expected_picture_svg_fixed_size.png (found 1652 pixels different) picture_svg_locked_aspectpicture_svg_locked_aspectTest failed at testRenderSvgLockedAspect at tests/src/python/test_qgsannotationpictureitem.py:619 Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_locked_aspect/expected_picture_svg_locked_aspect.png (found 775 pixels different) picture_svg_unlocked_aspectpicture_svg_unlocked_aspectTest failed at testRenderSvgUnlockedAspect at tests/src/python/test_qgsannotationpictureitem.py:646 Rendered image did not match tests/testdata/control_images/annotation_layer/expected_picture_svg_unlocked_aspect/expected_picture_svg_unlocked_aspect.png (found 3748 pixels different) Remote SVGRemote SVGTest failed at testRemoteSVG at tests/src/python/test_qgssvgcache.py:94 Rendered image did not match tests/testdata/control_images/svg_cache/expected_remote_svg/expected_remote_svg.png (found 2045 pixels different) Remote SVGRemote SVGTest failed at testRemoteSVGBlocking at tests/src/python/test_qgssvgcache.py:223 Rendered image did not match tests/testdata/control_images/svg_cache/expected_remote_svg/expected_remote_svg.png (found 2045 pixels different) Remote SVG as TextRemote SVG as TextTest failed at testRemoteSvgAsText at tests/src/python/test_qgssvgcache.py:131 Failed because rendered image and expected image are different dimensions (100x89 v2 100x110) Remote SVG bad MIME typeRemote SVG bad MIME typeTest failed at testRemoteSvgBadMime at tests/src/python/test_qgssvgcache.py:166 Failed because rendered image and expected image are different dimensions (100x89 v2 100x100) The full test report (included comparison of rendered vs expected images) can be found here. Further documentation on the QGIS test infrastructure can be found in the Developer's Guide. |
ci: upgrade to Fedora 41