Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions Dialogue Duplicate Button #57647

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

Speedrace4
Copy link
Contributor

@Speedrace4 Speedrace4 commented Jun 3, 2024

Description

Addresses this issue: #57399

Before screenshot:
image

After screenshot:
image

This adds a duplicate button to the layer properties actions dialogue. How it works: when a row is selected in the actions list, clicking the duplicate button will open a dialogue with all of the attributes of that row, allowing them to be edited. When clicking ok, it is submitted as a new row instead of editing the original.

Additionally, I edited the src/ui/qgsattributeactiondialogbase.ui file to put the components I was working with in order.

@github-actions github-actions bot added this to the 3.38.0 milestone Jun 3, 2024
@nyalldawson
Copy link
Collaborator

Would "duplicate" be more appropriate here vs "copy"? To me this action more closely follows other "duplicate" actions we have (eg duplicating symbol layers), vs "copy" (which implies more of a "copy" and then "paste" action).

@Speedrace4
Copy link
Contributor Author

Would "duplicate" be more appropriate here vs "copy"? To me this action more closely follows other "duplicate" actions we have (eg duplicating symbol layers), vs "copy" (which implies more of a "copy" and then "paste" action).

This makes sense, I will update the changes to reflect this

@Speedrace4 Speedrace4 changed the title Actions Dialogue Copy Button Actions Dialogue Duplicate Button Jun 3, 2024
@Speedrace4
Copy link
Contributor Author

Would "duplicate" be more appropriate here vs "copy"? To me this action more closely follows other "duplicate" actions we have (eg duplicating symbol layers), vs "copy" (which implies more of a "copy" and then "paste" action).

Done

@Speedrace4 Speedrace4 force-pushed the actions_copy_button branch 2 times, most recently from 7204efb to 399b987 Compare June 4, 2024 15:47
@nyalldawson nyalldawson added the Frozen Feature freeze - Do not merge! label Jun 6, 2024
@Speedrace4
Copy link
Contributor Author

@nyalldawson can I ask why this was frozen?

@nyalldawson
Copy link
Collaborator

@Speedrace4 we're in feature freeze for 3.38 now -- only features submitted before the freeze and which weren't reviewd in time were granted the "freeze exempt" status, features submitted during freeze need to wait till post 3.38 release before they can be merged.

@nyalldawson nyalldawson added Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. and removed Frozen Feature freeze - Do not merge! labels Jun 21, 2024
@qgis-bot
Copy link
Collaborator

@Speedrace4
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@nyalldawson nyalldawson enabled auto-merge (rebase) June 21, 2024 21:22
Copy link

github-actions bot commented Jun 21, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit bd5a887)

auto-merge was automatically disabled June 22, 2024 04:59

Head branch was pushed to by a user without write access

@nyalldawson nyalldawson merged commit 652dd51 into qgis:master Jun 23, 2024
28 checks passed
@qgis-bot
Copy link
Collaborator

@Speedrace4
A documentation ticket has been opened at qgis/QGIS-Documentation#9145
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@Speedrace4
Copy link
Contributor Author

Woooo first PR ever! :)

@Speedrace4 Speedrace4 deleted the actions_copy_button branch June 24, 2024 23:06
@pigreco
Copy link
Contributor

pigreco commented Aug 10, 2024

@Speedrace4

Woooo first PR ever! :)

But it's not in QGIS 3.38, why?
image

@agiudiceandrea
Copy link
Contributor

But it's not in QGIS 3.38, why?

See #57647 (comment)

@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Sep 24, 2024
@qgis-bot
Copy link
Collaborator

@Speedrace4

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants