-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions Dialogue Duplicate Button #57647
Conversation
Would "duplicate" be more appropriate here vs "copy"? To me this action more closely follows other "duplicate" actions we have (eg duplicating symbol layers), vs "copy" (which implies more of a "copy" and then "paste" action). |
This makes sense, I will update the changes to reflect this |
ccf35d4
to
9f73437
Compare
Done |
7204efb
to
399b987
Compare
399b987
to
89166f2
Compare
@nyalldawson can I ask why this was frozen? |
@Speedrace4 we're in feature freeze for 3.38 now -- only features submitted before the freeze and which weren't reviewd in time were granted the "freeze exempt" status, features submitted during freeze need to wait till post 3.38 release before they can be merged. |
@Speedrace4 A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
Head branch was pushed to by a user without write access
89166f2
to
bd5a887
Compare
@Speedrace4 |
Woooo first PR ever! :) |
|
See #57647 (comment) |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
Description
Addresses this issue: #57399
Before screenshot:
After screenshot:
This adds a duplicate button to the layer properties actions dialogue. How it works: when a row is selected in the actions list, clicking the duplicate button will open a dialogue with all of the attributes of that row, allowing them to be edited. When clicking ok, it is submitted as a new row instead of editing the original.
Additionally, I edited the src/ui/qgsattributeactiondialogbase.ui file to put the components I was working with in order.