Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Examples #13

Open
ghost opened this issue Dec 5, 2023 · 1 comment
Open

Simplify Examples #13

ghost opened this issue Dec 5, 2023 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@ghost
Copy link

ghost commented Dec 5, 2023

Is your feature request related to a problem? Please describe.
When having a look at the examples, it is not clear right away, how a variable should look, because it is hidden away in a local. This is even worse in the README, as the local.tf is nowhere integrated.

Describe the solution you'd like
Remove locals completely from examples and hardcode the values.

Describe alternatives you've considered
The only upside of locals is, that you can reuse the values. But as examples are examples, there is no need to reuse values.

@ghost ghost added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Dec 5, 2023
@ghost
Copy link
Author

ghost commented Dec 5, 2023

Furthermore the Network security rule has nothing to do with the module and should also be removed

@ghost ghost changed the title Simplify Advance Example Simplify Examples Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

0 participants