Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location variable #7

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Fix location variable #7

merged 9 commits into from
Apr 12, 2024

Conversation

QBY-MarkusMaring
Copy link
Member

Description

The default_location is not needed by the module and should be removed.

Change overview (tick true):

  • This introduces backward incompatible changes
  • This adds a new backward compatible Feature
  • This fixes a Bug

Version information:

  • Previous Version: 1.2.0

How Has This Been Tested?

  • Apply of all examples was successful

Checklist:

  • I have run tests and documented them above
  • I have performed a self-review of my own code
  • I have updated the documentation
  • I have updated the CHANGELOG

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an explanation, wha the regexes do.
And only allow POrt 53 to the DNS resolver

ghost
ghost previously approved these changes Apr 10, 2024
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
Co-authored-by: Thimo Limpert <[email protected]>
QBY-MarkusMaring and others added 2 commits April 10, 2024 10:30
Co-authored-by: Thimo Limpert <[email protected]>
Co-authored-by: Thimo Limpert <[email protected]>
@QBY-MarkusMaring QBY-MarkusMaring merged commit 2671d4a into main Apr 12, 2024
1 check passed
@QBY-MarkusMaring QBY-MarkusMaring deleted the fix/location-variable branch April 12, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant