Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] rtmp: panic in SetChunkSize msg #331

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jaesung9507
Copy link
Contributor

panic: runtime error: index out of range [3] with length 0

goroutine 115834580 [running]:
encoding/binary.bigEndian.Uint32(...)
        /usr/local/go/src/encoding/binary/binary.go:157
github.com/q191201771/naza/pkg/bele.BeUint32(...)
        /home/jaesung/go/pkg/mod/github.com/q191201771/[email protected]/pkg/bele/bele.go:35
github.com/q191201771/lal/pkg/rtmp.(*ChunkComposer).RunLoop(0xc005c87ba0, {0x7f268208a638, 0xc017ab1c30}, 0xc01bcebf38)
        /home/jaesung/src/lal/pkg/rtmp/chunk_composer.go:186 +0x187e
github.com/q191201771/lal/pkg/rtmp.(*ServerSession).runReadLoop(...)
        /home/jaesung/src/lal/pkg/rtmp/server_session.go:201
github.com/q191201771/lal/pkg/rtmp.(*ServerSession).RunLoop(0xc00162e540)
        /home/jaesung/src/lal/pkg/rtmp/server_session.go:132 +0xbc
github.com/q191201771/lal/pkg/rtmp.(*Server).handleTcpConnect(0xc000416270, {0x10d41d0, 0xc00513e700})
        /home/jaesung/src/lal/pkg/rtmp/server.go:102 +0xe5
created by github.com/q191201771/lal/pkg/rtmp.(*Server).RunLoop
        /home/jaesung/src/lal/pkg/rtmp/server.go:86 +0x25

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (181e594) 56.26% compared to head (5f32142) 56.16%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   56.26%   56.16%   -0.11%     
==========================================
  Files         132      132              
  Lines       11447    11448       +1     
==========================================
- Hits         6441     6430      -11     
- Misses       4316     4324       +8     
- Partials      690      694       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@q191201771 q191201771 merged commit 92252c8 into q191201771:master Nov 14, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants