-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for stereo/multichannel input #4
Comments
Thanks, I’d love to help here. How do you envision stereo support? Do you think that the limiter needs to process 2-channel information together to estimate the gain, or is it sufficient to create a limiter instance per each channel? In the latter case you could probably use it as is. |
Hmm, I haven't thought so much about the details, but here are two quick cents cent 1: cent 2 (alternative approach):
What do professional limiters, like Waves L2 do with stereo audio? |
https://www.izotope.com/en/learn/an-introduction-to-limiters-and-how-to-use-them.html Ok, so applying the limiter to each channel individually could actually be an option |
https://gearspace.com/board/mastering-forum/592906-stereo-link-mastering-limiter.html It seems some audio engineers like their limiter stereo-linked, some like it unlinked, others prefer something in-between (e.g. 70% linked). If we want to cater to everyone, we need a parameter that controls how "linked" the channel gains should be if the input is multichannel. In other words, a float in the range [0.0, 1.0] |
OK, I'll try to look into it in the following days. |
Hey guys, professional audio mix engineer here 🙂 Yeah usually there is a "stereo link" option that you can turn on and off, and in advanced cases you can mix them together with a mix knob keeping the gain (or power?) the same. I'm looking at adding a limiter to one of my apps and at first glance this seems like a great fit :) let me know if you have any questions or want any input from a professional in the audio industry! I can also maybe contribute some if I have time, though I primarily work in Python and somewhat limited experience in C++. |
Hi there! Sorry for a long time to reply, I was traveling. If you'd like to contribute the stereo link feature that would be awesome! If I understand it right, you'd basically need to modify the code to:
Let me know if you'd be picking it up. |
I'd love to add a wrapper for this limiter in audiomentations. In that context it would be nice to have support for stereo, so e.g. the music source separation community can enjoy the transform.
For now I will set
supports_multichannel = False
The text was updated successfully, but these errors were encountered: