Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add conversions from v1 node and storage threshold parameters #319

Merged
merged 1 commit into from
Dec 30, 2024
Merged

feat: add conversions from v1 node and storage threshold parameters #319

merged 1 commit into from
Dec 30, 2024

Conversation

Batch21
Copy link
Contributor

@Batch21 Batch21 commented Dec 21, 2024

No description provided.

@Batch21
Copy link
Contributor Author

Batch21 commented Dec 21, 2024

@jetuk the other 4 threshold parameters added to the v1 schema (MultipleThresholdIndex, MultipleThresholdParameterIndex, CurrentYearThreshold, and CurrentOrdinalDayThreshold) look like they'll need new v2 parameter implementations.

Happy to push these to this branch when done or make a new PR.

@jetuk
Copy link
Member

jetuk commented Dec 22, 2024

CurrentYearThreshold and CurrentOrdinalDayThreshold

These two could possibly be IndexMetric variants once #317 is merged.

The core implementation of ThresholdParameter could be made generic to the index and threshold, and then implemented for f64 and usize.

@jetuk jetuk merged commit b972e16 into main Dec 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetuk jetuk jetuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Batch21 @jetuk