Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index (usize) metric improvements. #291

Open
3 tasks
jetuk opened this issue Nov 22, 2024 · 2 comments · May be fixed by #317
Open
3 tasks

Index (usize) metric improvements. #291

jetuk opened this issue Nov 22, 2024 · 2 comments · May be fixed by #317

Comments

@jetuk
Copy link
Member

jetuk commented Nov 22, 2024

The current DynamicIndexValue is the usize equivalent of Metric. I think the former should brought more inline with the later setup. This would remove the nested enums in favour of a more "flat" approach. Tasks:

  • Use ParameterReference instead of String
  • Support index (usize) timeseries
  • Support indes (usize) inter-network transfers
@jetuk
Copy link
Member Author

jetuk commented Nov 22, 2024

Do this after #280 has been merged.

@jetuk jetuk linked a pull request Dec 17, 2024 that will close this issue
@jetuk
Copy link
Member Author

jetuk commented Jan 2, 2025

The type should probably be u64 and not the platform specific usize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant