Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input & output units, documentation, etc. #34

Open
jetuk opened this issue Jan 10, 2018 · 0 comments
Open

Input & output units, documentation, etc. #34

jetuk opened this issue Jan 10, 2018 · 0 comments

Comments

@jetuk
Copy link
Member

jetuk commented Jan 10, 2018

pycatchmod is a bit funny as it takes inputs in mm/day for rainfall and PET, but also wants an area in km^2. The output flow is then Ml/day. None of these are SI units and the output is different to the input.

  1. This needs better documentation in the docstrings, etc.
  2. There is an argument to make the whole library work with SI units (perhaps with the exception of days for time). So input would b m/day output would be m^3/day. However this would be a backward incompatible change that could be quite dangerous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant