Add capability to monitor for silence in geographic gathering #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for adding a timeout, improve the region collector unit test.
Added a unit test to test that monitor for silence is working as specified.
Add a test to the geographic gatherer to test that it's initiating the region collector with the silence keyword when such a silence is included in the configuration file.
Add functionality to monitor for silence in the geographic gatherer.
Document the recently introduced silence monitoring feature.
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 83.33% 83.52% +0.18%
==========================================
Files 19 19
Lines 2622 2652 +30
==========================================
+ Hits 2185 2215 +30
Misses 437 437
Continue to review full report at Codecov.
|
|
I'm currently field-testing this (along with #92, without which the geographic gatherer doesn't start). |
|
Initial field-testing indicates it is not entirely working as expected, so I'm marking this as a draft again for now. |
It doesn't DWIM. Add failing test to reproduce this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to monitor for silence in geographic gathering. This adds a timeout calculation that is triggered at a certain time after the most recent message has arrived. This allows for early shipping if a reception system has stopped delivering earlier than expected or if the region is defined too large.
Work in progress. So far only the tests have been added.