Fixes to prep for weights_only default flip #2514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
mikaylagawarecki
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
mikaylagawarecki
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
mikaylagawarecki
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
cc @kit1980, can you help review this? |
| @@ -29,7 +31,13 @@ def __init__(self, test, device, batch_size=None, extra_args=[]): | |||
| ) | |||
|
|
|||
| self.model = models.resnet18(num_classes=10) | |||
| prev_wo_envvar = os.environ.get("TORCH_FORCE_NO_WEIGHTS_ONLY_LOAD", None) | |||
There was a problem hiding this comment.
We don't have access to the torch.load call within opacus here, updating opacus also won't help because torchbench doesn't depend on a nightly of opacus but rather stable release
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 21, 2024
Summary: Some fixes for pytorch/pytorch#137602 Reviewed By: xuzhao9 Differential Revision: D64628614 Pulled By: mikaylagawarecki
mikaylagawarecki
force-pushed
the
wo_fix
branch
from
bedde13
to
5cd7016
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64628614 |
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 21, 2024
Summary: Some fixes for pytorch/pytorch#137602 Reviewed By: xuzhao9 Differential Revision: D64628614 Pulled By: mikaylagawarecki
mikaylagawarecki
force-pushed
the
wo_fix
branch
from
5cd7016
to
5303250
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64628614 |
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
Summary: Some fixes for pytorch/pytorch#137602 Reviewed By: xuzhao9 Differential Revision: D64628614 Pulled By: mikaylagawarecki
mikaylagawarecki
force-pushed
the
wo_fix
branch
from
5303250
to
4b5248c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64628614 |
mikaylagawarecki
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
mikaylagawarecki
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@mikaylagawarecki merged this pull request in fb590d9. |
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 22, 2024
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 22, 2024
Summary: Pull Request resolved: pytorch#2524 Differential Revision: D64771621 Pulled By: mikaylagawarecki
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 24, 2024
Summary: Some fixes for pytorch/pytorch#137602 Pull Request resolved: pytorch#2514 Reviewed By: xuzhao9 Differential Revision: D64628614 Pulled By: mikaylagawarecki fbshipit-source-id: edebf25cc6648919d5673a3baeaffdac26e5b91f
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: pytorch#2524 Differential Revision: D64771621 Pulled By: mikaylagawarecki
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: pytorch#2524 Differential Revision: D64771621 Pulled By: mikaylagawarecki
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 24, 2024
Summary: Pull Request resolved: pytorch#2524 Differential Revision: D64771621 Pulled By: mikaylagawarecki
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 25, 2024
Summary: Some fixes for pytorch/pytorch#137602 Pull Request resolved: pytorch#2514 Reviewed By: xuzhao9 Differential Revision: D64628614 Pulled By: mikaylagawarecki fbshipit-source-id: edebf25cc6648919d5673a3baeaffdac26e5b91f
mikaylagawarecki
added a commit
to mikaylagawarecki/benchmark
that referenced
this pull request
Oct 25, 2024
Summary: Pull Request resolved: pytorch#2524 Reviewed By: kit1980 Differential Revision: D64771621 Pulled By: mikaylagawarecki fbshipit-source-id: 545f3d528cfbe2668c8d37e98e99423cd77a8e8e
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 25, 2024
Summary: Some fixes for pytorch/pytorch#137602 Pull Request resolved: #2514 Reviewed By: xuzhao9 Differential Revision: D64628614 Pulled By: mikaylagawarecki fbshipit-source-id: edebf25cc6648919d5673a3baeaffdac26e5b91f
mikaylagawarecki
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for pytorch/pytorch#137602