gh-127187: Set correct __module__ attribute for methods of named tuple types
#127188
+66
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
requested review from
JelleZijlstra,
AlexWaygood and
rhettinger
as code owners
XuehaiPan
commented
Nov 23, 2024
Lib/collections/__init__.py
Outdated
| method.__qualname__ = f'{typename}.{method.__name__}' | ||
| if module is not None: | ||
| method.__module__ = module |
There was a problem hiding this comment.
I wonder if we need to check module is a str object. In the test, the module argument can be passed with collections (an instance of ModuleType).
|
I think this PR is still valuable. It avoids potential bugs if there is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set correct
__module__attribute for methods of named tuple types.Fixes #127187
__module__attribute forNamedTupleType.__new__method:namedtuple_{typename}#127187