Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be gentler on introspection #7

Open
pganssle opened this issue Dec 8, 2017 · 0 comments
Open

Be gentler on introspection #7

pganssle opened this issue Dec 8, 2017 · 0 comments

Comments

@pganssle
Copy link
Member

pganssle commented Dec 8, 2017

Since we're using decorators here, I think we're wiping out certain aspects of introspection (such as introspection about the arguments and keyword arguments).

I think there are 4 options when solving this:

  1. Take on wrapt as a hard dependency and use it everywhere (not desirable)
  2. Take on wrapt as a soft dependency and silently upgrade if it's present. (Better, but it means introspection behavior may not be consistent between deployments)
  3. Take on wrapt as a soft dependency and add an option to primary to enable it (e.g. it's optionally a hard dependency, and the behavior is the same across deployments).
  4. Fix introspection ourselves without wrapt.

I think the best option is 4, but if it's too hard or a big maintenance nightmare, I think 3 is the second-best solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant