Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix corner case of empty intersection in streetscape #674

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

martinfleis
Copy link
Member

This should not happen as we filter in sindex query first. Yet, it does.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.1%. Comparing base (4037c70) to head (f952295).
Report is 99 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #674     +/-   ##
=======================================
+ Coverage   97.4%   98.1%   +0.8%     
=======================================
  Files         26      40     +14     
  Lines       4328    7208   +2880     
=======================================
+ Hits        4214    7074   +2860     
- Misses       114     134     +20     
Files with missing lines Coverage Δ
momepy/streetscape.py 97.6% <100.0%> (ø)

... and 1 file with indirect coverage changes

@martinfleis martinfleis merged commit ce91ba2 into pysal:main Nov 27, 2024
15 checks passed
@martinfleis martinfleis deleted the empty-intersection branch November 27, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant