Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GenericRules is using sum() in counter metrics #1235

Open
jenciso opened this issue Aug 5, 2024 · 3 comments
Open

The GenericRules is using sum() in counter metrics #1235

jenciso opened this issue Aug 5, 2024 · 3 comments

Comments

@jenciso
Copy link

jenciso commented Aug 5, 2024

The Generic rules:

  • pyrra_requests_total (See here and here also)
  • pyrra_errors_total (See here)
    Are using sum() Prometheus functions without use before rate(). It generates peaks and obviously, it doesn't make sense sum counters if you don't use rate before, it is explained here

It seems a bug. Please let me know if I am wrong.
Thank you

@jenciso
Copy link
Author

jenciso commented Aug 5, 2024

@metalmatze Sorry for interrupting you, I would like you to have the chance to see this question. I appreciate any help you can provide.

@metalmatze
Copy link
Member

Hey, unfortunately, you're right.
There's already an issue here. Right now I have little time to fix the problem: #968

@metalmatze
Copy link
Member

If you know how to fix it, a PR would be greatly appreciated!
I'm busy organizing PromCon until mid-September...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants