Add param_store.py type hints
#3271
Conversation
| constrained_value = transform_to(constraint)(unconstrained_value) | ||
| constrained_value.unconstrained = weakref.ref(unconstrained_value) | ||
| constrained_value: torch.Tensor = transform_to(constraint)(unconstrained_value) | ||
| constrained_value.unconstrained = weakref.ref(unconstrained_value) # type: ignore[attr-defined] |
There was a problem hiding this comment.
neat, I haven't seen the error-specific type: ignore[-] syntax before. Did you add it manually, or via an IDE that automatically finds the narrowest ignore?
There was a problem hiding this comment.
It's an output from mypy error message:
pyro/params/param_store.py:134: error: "Tensor" has no attribute "unconstrained" [attr-defined]
But github copilot is also pretty good at finding those.
There was a problem hiding this comment.
Also described here: https://mypy.readthedocs.io/en/stable/common_issues.html#spurious-errors-and-locally-silencing-the-checker
You can use the form # type: ignore[<code>] to only ignore specific errors on the line. This way you are less likely to silence unexpected errors that are not safe to ignore, and this will also document what the purpose of the comment is. See Error codes for more information.
Replaces #3148