Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-funsor arguments to ops #489

Closed
4 tasks done
fritzo opened this issue Mar 13, 2021 · 2 comments
Closed
4 tasks done

Support for non-funsor arguments to ops #489

fritzo opened this issue Mar 13, 2021 · 2 comments
Assignees
Labels

Comments

@fritzo
Copy link
Member

fritzo commented Mar 13, 2021

This issue tracks changes needed to support non-funsor args as in @ordabayevy's #482, e.g.

ops.sum(Tensor(data), -1, keepdims=True)
# -op-dispatch-> Unary(ops.SumOp(-1, True), Tensor(data))
# -eager-> Tensor(ops.SumOp(-1,True)(data))  # TODO fix batch dimension handling

Plan

Note during the first two refactorings, we may want to try to decouple dispatch tables from the Op hierarchy (but that would be a bigger refactoring, possibly beyond the scope of this issue).

@eb8680
Copy link
Member

eb8680 commented Mar 24, 2021

Can this be closed now that #482 is merged?

@fritzo
Copy link
Member Author

fritzo commented Mar 24, 2021

Yes, thanks for your help @ordabayevy !

@fritzo fritzo closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants