Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(get-pestpp): add get-pestpp command line interface #457

Merged
merged 8 commits into from
Sep 5, 2023

Conversation

jdhughes-usgs
Copy link
Contributor

No description provided.

@jdhughes-usgs jdhughes-usgs marked this pull request as draft August 31, 2023 22:57
@coveralls
Copy link

Coverage Status

coverage: 77.803% (-2.0%) from 79.841% when pulling f942bdd on jdhughes-usgs:get-pestpp-cli into 0aa1985 on pypest:develop.

@briochh
Copy link
Collaborator

briochh commented Sep 1, 2023

@jdhughes-usgs just noting this in here. Looks like the failing tests are related to pandas 2.1 update and pd.read_csv() with delim_whitespace. Looks unrelated to your PR.

* add documentation for get-pestpp
* update meras_trEnhance.pval to remove extra column on one line
@jdhughes-usgs
Copy link
Contributor Author

jdhughes-usgs commented Sep 1, 2023

@briochh There were three columns in one line of one example dataset that was causing the pandas problem. Let me know if this is not a valid fix.

@briochh
Copy link
Collaborator

briochh commented Sep 2, 2023

@jdhughes-usgs, yeah but I think that the "extra" column was split by a comma. @jtwhite79, might be able to comment on whether the comma is valid in there, think it has always been there. Looks like the delim_whitespace=True option now still splits on ,, which is a bit weird.

Man, spending a lot of time chasing breaking changes these days!

@jdhughes-usgs
Copy link
Contributor Author

@jdhughes-usgs, yeah but I think that the "extra" column was split by a comma. @jtwhite79, might be able to comment on whether the comma is valid in there, think it has always been there. Looks like the delim_whitespace=True option now still splits on ,, which is a bit weird.

Man, spending a lot of time chasing breaking changes these days!

@briochh It was split by a comma. It was the only line with an extra comma. Hopefully @jtwhite79 can let me know what needs to be done.

@briochh
Copy link
Collaborator

briochh commented Sep 2, 2023

@jdhughes-usgs pin pandas? pandas-dev/pandas#54918

@jdhughes-usgs
Copy link
Contributor Author

@briochh could do that but could be something that bites later on.

@jdhughes-usgs jdhughes-usgs marked this pull request as ready for review September 2, 2023 00:57
@jtwhite79 jtwhite79 merged commit 78523a4 into pypest:develop Sep 5, 2023
10 checks passed
@jdhughes-usgs jdhughes-usgs deleted the get-pestpp-cli branch September 6, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants