Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv creation broken by filelock 3.15.0 release #2735

Open
tamird opened this issue Jun 12, 2024 · 8 comments
Open

virtualenv creation broken by filelock 3.15.0 release #2735

tamird opened this issue Jun 12, 2024 · 8 comments
Labels

Comments

@tamird
Copy link

tamird commented Jun 12, 2024

Creating virtualenv root in /codebuild/output/src4294789612/src/actions-runner/_work/python_monorepo/python_monorepo/.venv

object.__init__() takes exactly one argument (the instance to initialize)
Exception ignored in: <function BaseFileLock.__del__ at 0x7f8ac1d91760>
Traceback (most recent call last):
  File "/root/.local/share/pipx/venvs/poetry/lib/python3.11/site-packages/filelock/_api.py", line 365, in __del__
    self.release(force=True)
  File "/root/.local/share/pipx/venvs/poetry/lib/python3.11/site-packages/virtualenv/util/lock.py", line 34, in release
    with self.thread_safe:
         ^^^^^^^^^^^^^^^^
AttributeError: '_CountedFileLock' object has no attribute 'thread_safe'

tox-dev/filelock#334 looks the likeliest culprit.

@rlizzo
Copy link

rlizzo commented Jun 12, 2024

+1 this issue is occuring for us as well

@EarningsCall
Copy link

Wow, searching far and wide and just now found this issue. Looks like it's happening to everyone!

For me, I'll just pin filelock for the time being:

pip install --upgrade hatch filelock==3.14.0

@schmod
Copy link

schmod commented Jun 12, 2024

The offending version of filelock has been yanked from PyPi, so this should basically be resolved. You might need to force a reinstallation of virtualenv (or whatever depended on it).

@susodapop
Copy link

susodapop commented Jun 12, 2024

Note to others: if you're GH Actions checks are failing you may need to purge your env caches that are created by actions/cache@v2

[edit] I removed my edit because I accidentally posted on the wrong repository! Apologies for the noise 🙏

@edgarrmondragon
Copy link

edgarrmondragon commented Jun 19, 2024

I think this has resurfaced with filelock 3.15.2?

@benjamin-awd
Copy link

Looks like 3.15.2 just got yanked from PyPI

image

@jkanche
Copy link

jkanche commented Jun 19, 2024

Just noticed 3.15.2 is also yanked from PyPI

@sdmitriev1
Copy link

3.15.3 was released, fixed the problem for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants