Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always normalize RECORD files to forward-slash when writing #158

Open
pradyunsg opened this issue Dec 13, 2022 · 1 comment
Open

Always normalize RECORD files to forward-slash when writing #158

pradyunsg opened this issue Dec 13, 2022 · 1 comment
Labels
component: records Related to installer.records type: task Something that needs to be done that is not a bug or feature

Comments

@pradyunsg
Copy link
Member

We should unconditionally do path.replace("\\", "/") in RecordEntry.to_row, since we might read a path from a Windows-generated RECORD (or on Windows) and need to normalise it to use / unconditionally.
@pradyunsg pradyunsg added type: task Something that needs to be done that is not a bug or feature component: records Related to installer.records labels Dec 13, 2022
@uranusjr
Copy link
Member

It’s probably better to use WindowsPurePath from pathlib and do a as_posix to normalise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: records Related to installer.records type: task Something that needs to be done that is not a bug or feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uranusjr @pradyunsg