Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: find all runtimeError-capable lines and make sure they are guarded #198

Open
tlambert03 opened this issue Sep 22, 2023 · 1 comment

Comments

@tlambert03
Copy link
Member

It would be a handy thing to know, a priori, what calls to mmcore are likely to cause RuntimeErrors (or other errors) in a config-dependent way. And make sure that we're catching and handling them appropriately throughout the widgets here.

A manual approach might be looking through the CMMCore code and seeing what throws. or an automated approach could to load either no config or the demo config, and just try calling all of the methods with type-appropriate values... Some will just return sane defaults (like getPixelSizeUm) while others will raise exceptions.

Then, we can look through the code here and make sure we have appropriate error handling logic in place.

@tlambert03
Copy link
Member Author

see, for example, pymmcore-plus/napari-micromanager#288 ... where each problem fixed gradually reveals a new problem on a new, untested config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant