-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svg.disabled= true cripple uBlock origin "Block this element" feature #305
Comments
If you turn it to true, does the Element picker work? |
Yes. I found the culprit was this setting by using dichotomy. svg.enabled = false there is no pink overlay (the other window still works as intended) For the record : i was using an old user.js version, from here, until today i had no problems. I manually merged the changes from the last commit and i saw that problem. It should definitely comes from a "new" setting, and this one was indeed "new" for me |
The highlight is javascript and not SVG. |
Ikr. But still : disabling "svg" cause the mentioned problem. And btw i was wrong. the actual setting is svg.disabled not enabled. Set it to true caused the problem, false is ok. and btw if you read carefully the mentionned JS fonction : svgOcean.setAttribute('d', ocean.join('')); Bingo, svg.. Its just a variable name but i mean..it was chosen on purpose i guess |
Thanks for letting us know!
It's not their problem IMO 😃 Cross-reference to the SVG PR: #276 |
@MikeZeDev Can you change the title?
Yes, IMHO |
@Atavic I think its not uBo problem too. Anyway, changed title :) |
Fixed in 6ee951e. |
Tested on a fresh FF profile with a fresh uBO install.
When i right click on a webpage and click on "Block this element" this setting prevent the pink overlay used for selection to be displayed.
I know many settings may break some websites or addons features and i am not complaining, nor requesting a "fix". I just let people know by filling this issue
Should i contact gorhill?
The text was updated successfully, but these errors were encountered: