Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg.disabled= true cripple uBlock origin "Block this element" feature #305

Closed
MikeZeDev opened this issue May 26, 2017 · 8 comments
Closed

Comments

@MikeZeDev
Copy link

MikeZeDev commented May 26, 2017

Tested on a fresh FF profile with a fresh uBO install.

When i right click on a webpage and click on "Block this element" this setting prevent the pink overlay used for selection to be displayed.

I know many settings may break some websites or addons features and i am not complaining, nor requesting a "fix". I just let people know by filling this issue

Should i contact gorhill?

@Atavic
Copy link

Atavic commented May 26, 2017

If you turn it to true, does the Element picker work?

@MikeZeDev
Copy link
Author

MikeZeDev commented May 26, 2017

Yes. I found the culprit was this setting by using dichotomy.
The only setting left in my "test" user.js was this one.

http://imgur.com/fOP2bRL

svg.enabled = false there is no pink overlay (the other window still works as intended)
svg.enabled = true, no problems

For the record : i was using an old user.js version, from here, until today i had no problems. I manually merged the changes from the last commit and i saw that problem. It should definitely comes from a "new" setting, and this one was indeed "new" for me

@Atavic
Copy link

Atavic commented May 26, 2017

The highlight is javascript and not SVG.

@MikeZeDev
Copy link
Author

MikeZeDev commented May 26, 2017

Ikr. But still : disabling "svg" cause the mentioned problem.

And btw i was wrong. the actual setting is

svg.disabled not enabled.

Set it to true caused the problem, false is ok.

and btw if you read carefully the mentionned JS fonction :

svgOcean.setAttribute('d', ocean.join(''));
svgIslands.setAttribute('d', islands.join('') || 'M0 0');

Bingo, svg.. Its just a variable name but i mean..it was chosen on purpose i guess

@pyllyukko
Copy link
Owner

Thanks for letting us know!

Should i contact gorhill?

It's not their problem IMO 😃

Cross-reference to the SVG PR: #276

@Atavic
Copy link

Atavic commented May 27, 2017

@MikeZeDev Can you change the title?

Should i contact gorhill?

Yes, IMHO

@MikeZeDev
Copy link
Author

MikeZeDev commented May 27, 2017

@Atavic I think its not uBo problem too. Anyway, changed title :)

@MikeZeDev MikeZeDev changed the title svg.enabled = false cripple uBlock origin "Block this element" feature svg.disabled= true cripple uBlock origin "Block this element" feature May 27, 2017
@pyllyukko
Copy link
Owner

Fixed in 6ee951e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants