New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include pre-commit in optional dependencies #630

Merged

almarklein merged 1 commit into pygfx:main from claydugo:include_precommit_dev

Oct 24, 2024

Contributor

claydugo commented Oct 23, 2024 •

edited

Loading

@fyellin pointed out that the current instructions in the README are not clear as to how a contributor may leverage pre-commit as a tool.

I have included it in the pip -e .[dev]. install as suggested and updated the reference in the README to point to the projects github landing page.


          Include pre-commit in optional dependencies

c967095

changfe link to github

claydugo requested a review from Korijn as a code owner

October 23, 2024 19:25

Korijn approved these changes

View reviewed changes

Member

almarklein commented Oct 24, 2024

Thanks for @fyellin for pointing this out and for @claydugo for fixing this so quickly :) 🚀

almarklein merged commit c0cc97f into pygfx:main

21 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet