Fix snake case for 1d/2d/3d suffix #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Locally the failing test works. I'll wait for the nice diff error in #614. |
|
Oh, now the codegen test passes. Was I seeing the ruff flakiness? Anyway, ready. |
Korijn
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In responding to pygfx/pygfx#863, I realized that
gfx.renderers.wgpu.set_wgpu_limits(max_texture_dimension_3d=...)does not work, butgfx.renderers.wgpu.set_wgpu_limits(max_texture_dimension3d=...)does. While in fact wgpu uses the former notation, as is shown in the error message:This PR fixes that, and keeps the old notation working too:
max_texture_dimension3dstill resolves tomaxTextureDimension3D.We have two implementations of
to_snake_case()andto_camel_case(), because the codegen does not import from wgpu. This PR also makes them the same again (the diverged a little.The codegen is actually not affected. Only the way that custom limits and such are handled.