Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to testing #604

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fixes to testing #604

merged 2 commits into from
Sep 27, 2024

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Sep 27, 2024 •
edited
Loading

Closes #600

  • Update the logic to determine whether wgpu can be used (was done in a weird way to avoid panic).
  • Put example testutils in own module.
  • Enable running pytest examples. Did not work on my machine (related to Fix that pytest examples does not always work pygfx#770).
  • Fix glfw test.
  • Fix that request_device did not obtain the surface id in the correct way.

@almarklein almarklein marked this pull request as ready for review September 27, 2024 11:17
@almarklein almarklein merged commit 087d729 into main Sep 27, 2024
20 checks passed
@almarklein almarklein deleted the testing branch September 27, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korijn Korijn Korijn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

branch "main" is failing on Mac running Python 12.
2 participants
@almarklein @Korijn