Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruff instead of black and flake8 #599

Merged
merged 13 commits into from
Sep 26, 2024
Merged

Use ruff instead of black and flake8 #599

merged 13 commits into from
Sep 26, 2024

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Sep 25, 2024 •
edited
Loading

Tasks

  • Use ruff for formatting in ci and codegen.
  • Change lint-dependencies.
  • Apply new formatting, and resolve conflicts between ruff and black.
  • Enable more linting rules and fix cases (some autofixed by ruff).

Review

Most changes are formatting or linting changes. The files of interest are:

  • README.md
  • pyproject.toml
  • .github/workflows/ci.yml
  • codegen/utils.py (the codegen needs to format the generated code)

@almarklein almarklein marked this pull request as ready for review September 26, 2024 09:08
@almarklein almarklein mentioned this pull request Sep 26, 2024
Open
@almarklein almarklein merged commit cf59eb0 into main Sep 26, 2024
20 checks passed
@almarklein almarklein deleted the ruff branch September 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korijn Korijn Korijn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almarklein @Korijn