Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor build system #596

Merged
merged 22 commits into from
Sep 24, 2024
Merged

Refactor build system #596

merged 22 commits into from
Sep 24, 2024

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Sep 20, 2024

Closes #585.

The approach to use cibuildwheel is somewhat overkill because we don't need to compile anything. And it does not even work properly. We added extra logic to make it work in #582 but then we still got #585. So I figured it can be done simpler, using the modern approach of a pyproject.toml.

  • Use pyproject.toml
  • Remove setup.py, dev-requirements.txt
  • Setup build system so it creates clean sdist and wheels.
  • Enable cross-platform builds.
  • Script to build all wheels. The wheels are checked extensively.
  • Update cd.yml, test wheels on 3 main platforms.

Korijn
Korijn previously approved these changes Sep 21, 2024
@almarklein almarklein marked this pull request as ready for review September 23, 2024 11:02
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@almarklein almarklein merged commit 5a0e691 into main Sep 24, 2024
20 checks passed
@almarklein almarklein deleted the build branch September 24, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows aarch64 wheel is named incorrectly
2 participants