Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loggers should never use f-strings #2047

Closed
Carreau opened this issue Nov 20, 2024 · 1 comment
Closed

Loggers should never use f-strings #2047

Carreau opened this issue Nov 20, 2024 · 1 comment

Comments

@Carreau
Copy link
Collaborator

Carreau commented Nov 20, 2024

it's not enable by default by ruff, but we likely should.

https://docs.astral.sh/ruff/rules/logging-f-string/

See #2044 (comment)_
@trallard trallard mentioned this issue Nov 20, 2024
Closed
@trallard
Copy link
Collaborator

Addressed already so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT - Update pre-commit hooks and config trallard/pydata-sphinx-theme
2 participants
@Carreau @trallard