support new numpy complex types

[tacaswell]

With numpy main compliing numexpr fails with (a lot) of errors that look like:

      numexpr/complex_functions.hpp: In function ‘void nc_assign(npy_cdouble*, npy_cdouble*)’:
      numexpr/complex_functions.hpp:36:6: error: request for member ‘real’ in ‘* r’, which is of non-class type ‘npy_cdouble’ {aka ‘__complex__ double’}
         36 |   r->real = x->real;
            |      ^~~~
      numexpr/complex_functions.hpp:36:16: error: request for member ‘real’ in ‘* x’, which is of non-class type ‘npy_cdouble’ {aka ‘__complex__ double’}
         36 |   r->real = x->real;
            |                ^~~~

I suspect the fix looks like scipy/scipy#18975 and is also a result of numpy/numpy#24085 / numpy/numpy#20880

[27rabbitlt]

Can you please provide a snippet of code? I'm unfamiliar with this numpy's new feature T_T.

[tacaswell]

numpexpr fails to compile with the numpy default branch.

I think this change won't go out in stable release until numpy 2

[seberg]

It's not a new feature, the NumPy main branch just tries to use the C99/C++11 definitions for complex. And those don't define ->real and ->imag so you need to replace it.

Since I bet you know that you have complex doubles, could probably just not use the NumPy types at all (so that you can use C++ .real() and .imag() no matter which NumPy it is) otherwise may need to cast or use some macro magic.

EDIT: But Thomas gave all the links to get an idea of how to best change it!

[27rabbitlt]

thanks I’ll try to fix this

…

On Wed, 29 Nov 2023 at 15:16, Sebastian Berg ***@***.***> wrote: It's not a new feature, the NumPy main branch just tries to use the C99/C++11 definitions for complex. And those don't define ->real and ->imag so you need to replace it. Since I bet you know that you have complex doubles, could probably just not use the NumPy types at all (so that you can use C++ .real() and .imag() no matter which NumPy it is) otherwise may need to cast or use some macro magic. — Reply to this email directly, view it on GitHub <#458 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A33BDH3IIPX6TTO6XIGBP5DYG47STAVCNFSM6AAAAAA7TGV4MKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRHE3TQOBQGE> . You are receiving this because you commented.Message ID: ***@***.***>

[tacaswell]

Closed by #461