You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a feature request covering multiple related feature additions surrounding the pybamm.step.string tags functionality. Currently there is the ability to add tags to pybamm step strings, and there is the ability to search an experiment for the indices where specific tags exist. There is not currently any additional functionality of the step string tags. The proposed added functionality is the following:
The ability to search a solution object for specific steps based on tags
The added functionality to export tags along with cycle and step indices when using the Solution.get_data_dict() method
Motivation
I believe these features are the would-be natural evolution of additional functionality surrounding step string tags. I believe the true utility of these step string tags come when you can use them to filter a solution object, or to filter data exported from a solution object.
Possible Implementation
Core Implementation
I believe there are a number of steps for the proposed core implementation.
Add a property to the Solution class: .tags
By default, when running an experiment, each time a step_solution is generated, the tags from the associated step (from the experiment) should then be assigned as a property to the Solution object
The method Solution.get_data_dict() should export a 'Tags' column along with 'Cycle' and 'Step' columns.
An additional method should be added: Solution.search_tags(), similar to Experiment.search_tag(), allowing for searching of one of many tags in the solution sub_solutions
Additional Features
I also believe there are a number of additional changes that may be useful to include as well
The inclusion of tags in the __repr__ of the Solution object
Similar to how tags would be associated with a Solution object (as a property), there may also be the properties .cycle and .step which are associated with a Solution when the solution results from an experiment.
The Solution object holds the additional variables, accessible through the __getitem__() method, being "Cycle", "Step", and "Tags"
Remaining Questions
Should calling Solution.get_data_dict() when there are no tags result in returning an empty "Tags" column, or no "Tags" column at all?
Additional context
No response
The text was updated successfully, but these errors were encountered:
Description
This is a feature request covering multiple related feature additions surrounding the
pybamm.step.string
tags functionality. Currently there is the ability to add tags to pybamm step strings, and there is the ability to search an experiment for the indices where specific tags exist. There is not currently any additional functionality of the step string tags. The proposed added functionality is the following:Solution.get_data_dict()
methodMotivation
I believe these features are the would-be natural evolution of additional functionality surrounding step string tags. I believe the true utility of these step string tags come when you can use them to filter a solution object, or to filter data exported from a solution object.
Possible Implementation
Core Implementation
I believe there are a number of steps for the proposed core implementation.
Solution
class:.tags
step_solution
is generated, the tags from the associated step (from the experiment) should then be assigned as a property to theSolution
objectSolution.get_data_dict()
should export a 'Tags' column along with 'Cycle' and 'Step' columns.Solution.search_tags()
, similar toExperiment.search_tag()
, allowing for searching of one of many tags in the solution sub_solutionsAdditional Features
I also believe there are a number of additional changes that may be useful to include as well
__repr__
of theSolution
objectSolution
object (as a property), there may also be the properties.cycle
and.step
which are associated with aSolution
when the solution results from an experiment.Solution
object holds the additional variables, accessible through the__getitem__()
method, being "Cycle", "Step", and "Tags"Remaining Questions
Solution.get_data_dict()
when there are no tags result in returning an empty "Tags" column, or no "Tags" column at all?Additional context
No response
The text was updated successfully, but these errors were encountered: