Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #136

Open
ItsDrike opened this issue Jun 21, 2023 · 0 comments
Open

Add integration tests #136

ItsDrike opened this issue Jun 21, 2023 · 0 comments
Labels
a: tests Related to unit or integration tests p: 3 - low This can wait s: stale Has had no activity for a while (will be closed for inactivity/marked up for grabs soon) t: feature New request or feature z: up for grabs Available for anyone to take over and work on

Comments

@ItsDrike
Copy link
Member

Currently, we're only using unit tests, which, as the name would suggest, only test the code in individual "units". This means that while we do make sure that the individual components of our code-base work on their own, we don't test that they work properly together.

Adding integration tests would mean for example adding in a workflow, which either connects to a well established server that we trust will always remain online, or spinning up the minecraft server within that workflow (probably via docker), and testing the interactions like that.

Ideally, we should be spinning up our own server, as that allows us to see the console output as well, allowing us to test not only that we've obtained the correct information on mcproto side, but also that for example a player join was handled normally and there aren't any unexpected logs in the console.

Another major reason to use our own server is that with popular servers that we could trust to remain online, we would need to use an official minecraft account, which would be connecting to this server, and performing various automated actions, which this server likely wouldn't like. The only realistic and viable option with these existing servers would be to test obtaining a status response.

@ItsDrike ItsDrike added p: 3 - low This can wait t: feature New request or feature a: tests Related to unit or integration tests labels Jun 21, 2023
@ItsDrike ItsDrike added the z: up for grabs Available for anyone to take over and work on label Aug 11, 2023
@py-mine-ci-bot py-mine-ci-bot bot added the s: stale Has had no activity for a while (will be closed for inactivity/marked up for grabs soon) label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests Related to unit or integration tests p: 3 - low This can wait s: stale Has had no activity for a while (will be closed for inactivity/marked up for grabs soon) t: feature New request or feature z: up for grabs Available for anyone to take over and work on
Projects
None yet
Development

No branches or pull requests

1 participant