Attach a,m,r binding in insert mode while in submit review buffer

[wd60622]

While in the submit review buffer, I would like to have <C-a>, <C-m>, and <C-r> bindings to work in insert mode as well.

Maybe you know a way around this @GuillaumeLagrange?

[wd60622]

The mappings are configurable and defined here:

https://github.com/wd60622/octo.nvim/blob/20a6f691fd1ebff763bcd504703ac729eb6f1ff3/lua/octo/config.lua#L269-L274

Then the mappings are applied here:

https://github.com/wd60622/octo.nvim/blob/20a6f691fd1ebff763bcd504703ac729eb6f1ff3/lua/octo/reviews/init.lua#L261-L280

Which only support normal mode :

https://github.com/wd60622/octo.nvim/blob/20a6f691fd1ebff763bcd504703ac729eb6f1ff3/lua/octo/utils.lua#L1564-L1569

[GuillaumeLagrange]

That's definitely doable, this issue should mostly be focused on how do we integrate the mode in our mappings.

My suggestion would be to add an optional property mode for mappings in our config, which can be

nil | string | string[] (or whatever a string table is in lua cats), and then if nil we default to n only, else we apply the mapping to all modes

These should be changeable in the confg default mappings, as well as overridden by user config.