Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate interface definition for RCT*.h on newer react versions #35

Open
kkortes opened this issue Sep 19, 2017 · 1 comment
Open

Comments

@kkortes
Copy link

kkortes commented Sep 19, 2017

Imports changed in react native v0.40 which broke this library (out of the box). The fix is rather simple:

Change:
// Accelerometer.m
#import "RCTBridge.h"
#import "RCTEventDispatcher.h"

To:
// Accelerometer.m
#import <React/RCTBridge.h>
#import <React/RCTEventDispatcher.h>

for Gyrometer.m, Accelerometer.m and Magnetometer.m.

Do you have any plans to match the newer versions of react native? Love this repo!

(I don't know if simply changing the imports to <> will solve the issue for older installations).

@pwmckenna
Copy link
Owner

Hi @kkortes , I don't use this repo anymore, so I probably won't get around to updating it with what you're suggesting, but if you'd like to do it and make a PR I'd happily add you as a contributor and help you get the fix out the door.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants