Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parties for non-friends not showing #2

Open
zerox003 opened this issue Oct 21, 2023 · 10 comments
Open

Parties for non-friends not showing #2

zerox003 opened this issue Oct 21, 2023 · 10 comments
Assignees

Comments

@zerox003
Copy link

any specific reason why the showing party feature got removed?
The one which shows which ppl are in the same squad. Thats like mainly why I used that tracker above others....

@CreepsoOff
Copy link

CreepsoOff commented Oct 21, 2023

It didn't get removed, still working on my side.

EDIT: Not working anymore now

@pwall2222 pwall2222 self-assigned this Oct 22, 2023
@pwall2222
Copy link
Owner

I have yet to fix this issue because it's something related to decoding the presences so it's gonna be tough. Don't expect this to work for the time being.

@Nenormaln1
Copy link

Do you know if it's even possible to fix by now?

@pwall2222
Copy link
Owner

Do you know if it's even possible to fix by now?

I am not sure yet, but I will close this issue if it can't be fixed.

@pwall2222
Copy link
Owner

Right now this issue will be stale for a while. Because RiotGames changed how their API works, we used to grab the PartyID from the local endpoint /chat/v4/presences but now that API only shows friends, which in part means that we can't fetch the PartyID for the players in our match. So we can't know who is premade.

TLDR; Can't look at parties because we can't get info from players

@pwall2222
Copy link
Owner

Update in the issue, I have seen some possibilities to show some kind of parties (not 100% accurate) but it will be better than not having any party indicators. It will take a while to implement.

Also for the technical details, the tracker.gg app uses last 20 matches to check if players have queued together and uses that to predict parties. Another way is thru an obscure endpoint feature that may or may not work.

@pwall2222
Copy link
Owner

I have a small update, the PartyID so the functionalty can be as good as before the API change can be retrieved via the messaging protocol of Riot (based off XMPP) so I am working in a side project to be able to bring that to NOWT. I don't have a estimated timeline so don't get too hyped but it'll be soon™.

@bossotron13
Copy link

update?

@pwall2222 pwall2222 changed the title Removed the party feature? Parties for non-friends not showing Jan 7, 2024
@pwall2222
Copy link
Owner

update?

There is no update. For personal and general reasons, I haven't been involved a lot on finishing this. But as I stated previously don't get your hopes up it will be "soon™" refering that it could be from now till the end on time.

References: Soon™

@mfreewill

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants