Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 404: This room does not exist as title of room page, even though room exists. #6

Open
KendallDoesCoding opened this issue Apr 22, 2023 · 8 comments · May be fixed by #23
Open

[BUG] 404: This room does not exist as title of room page, even though room exists. #6

KendallDoesCoding opened this issue Apr 22, 2023 · 8 comments · May be fixed by #23

Comments

@KendallDoesCoding
Copy link
Contributor

Even though room exists, and playable with 2 players online the title of the room page is as follows:

404: This room does not exist
@pushkaraj2007
Copy link
Owner

@KendallDoesCoding, would you like to work on this issue?

If anyone else wants to work on it, it's also fine if @KendallDoesCoding does not want to.

@KendallDoesCoding
Copy link
Contributor Author

@KendallDoesCoding, would you like to work on this issue?

If anyone else wants to work on it, it's also fine if @KendallDoesCoding does not want to.

Let me have a look at the code and see if I can fix this.. Don't assign me yet tho.

@saurabh190802
Copy link
Contributor

saurabh190802 commented Apr 24, 2023 •
edited
Loading

@pushkaraj2007 I have fixed this. Kindly check, will open a pr soon.

image

image

@KendallDoesCoding
Copy link
Contributor Author

@pushkaraj2007 I have fixed this. Kindly check, will open a pr soon.

image

image

Perfect. Please open the PR.

@saurabh190802
Copy link
Contributor

@pushkaraj2007 I have fixed this. Kindly check, will open a pr soon.
image
image

Perfect. Please open the PR.

Already there is a pr opened #11 after that getting merged I will open a pr for this.

@KendallDoesCoding
Copy link
Contributor Author

@pushkaraj2007 I have fixed this. Kindly check, will open a pr soon.
image
image

Perfect. Please open the PR.

Already there is a pr opened #11 after that getting merged I will open a pr for this.

Bro, why did you commit to main? You should've made a new branch and worked on #11 and then you could've made another branch and worked on this and made two PR's at a time? No worries tho, we are all in the learning process here 😄

@saurabh190802 saurabh190802 mentioned this issue Apr 24, 2023
Closed
@saurabh190802
Copy link
Contributor

@pushkaraj2007 I have fixed this. Kindly check, will open a pr soon.
image
image

Perfect. Please open the PR.

Already there is a pr opened #11 after that getting merged I will open a pr for this.

Bro, why did you commit to main? You should've made a new branch and worked on #11 and then you could've made another branch and worked on this and made two PR's at a time? No worries tho, we are all in the learning process here 😄

ok 🙂

@saurabh190802
Copy link
Contributor

opened a pr #17 kindly check

@saurabh190802 saurabh190802 linked a pull request May 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@saurabh190802 @KendallDoesCoding @pushkaraj2007